Adding battery example, notification ticker and gps example update #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def notify(self, title='', message='', app_name='', app_icon='', | ||
| timeout=10): | ||
| def notify(self, title='', message='', ticker='', app_name='', app_icon='', | ||
| timeout=10): |
There was a problem hiding this comment.
Adding a new keyword argument should happen at the end of the argument list, or people using them with direct values ("app name" instead of app_name="app name") will get a breakage.
|
@tshirtman updated!, please check if it's ok. 😄 |
|
Looks good to me :) 👍 |
tshirtman
added a commit
that referenced
this pull request
Mar 14, 2016
Adding battery example, notification ticker and gps example update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the screen shot of the battery example on android device.
And a screenshot showing the notification ticker (at the top).