Changes notify to use ctypes instead of win32gui so we could use unicode. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brousch
added a commit
that referenced
this pull request
Mar 14, 2014
Changes notify to use ctypes instead of win32gui so we could use unicode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the above, you can also create one instance and call notify as many times as you like with different messages on that instance.
I don't like the fact that we need to sleep inside the
__init__method, but I left it there for backward compatibility reasons. I could also add a close method which explicitly closes the balloon whenever you wish, but the (plyer notification) api doesn't seem to have an option for this.Finally, it doesn't show any icon on the systray, just in the balloon, but that could be changed as well to show an icon in the systray as well.