Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #107 - Use Android_ID instead of IMEI #133

Merged
merged 1 commit into from
May 9, 2015
Merged

fix #107 - Use Android_ID instead of IMEI #133

merged 1 commit into from
May 9, 2015

Conversation

aron-bordin
Copy link
Member

Using Android_ID.
Do I need to add something else?

@Kovak
Copy link
Contributor

Kovak commented May 3, 2015

An important observation:

[14:20] tito: use "from plyer.platforms.android import activity" instead of manually importing PythonActivity
[14:21] tito: otherwise the code will be broken when used in service
[14:21] tito: dessant: ie, use: https://github.com/kivy/plyer/blob/master/plyer/platforms/android/__init__.py

@aron-bordin
Copy link
Member Author

PR updated. Please, when possible, let me know if it's ok now.

@dessant
Copy link
Contributor

dessant commented May 4, 2015

Looks great, but we missed to merge this before refactoring the facades. Could you please update it and add a versionchanged tag with a short mention of the change on android? It should be merged right after that.

@aron-bordin
Copy link
Member Author

PR updated, check if it's ok

@dessant
Copy link
Contributor

dessant commented May 9, 2015

Thanks a lot. 👍

dessant added a commit that referenced this pull request May 9, 2015
fix #107 - Use Android_ID instead of IMEI
@dessant dessant merged commit 15e4d48 into kivy:master May 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants