vibrator for android v < 4.0 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,11 +1,7 @@ | |||
|
|
|||
| """Plyer Vibrator Example.""" | |||
There was a problem hiding this comment.
Simple, one-line docstrings like this don't add any information and should be avoided. (We know this is a Plyer Vibrator Example, because it's examples/vibrator/main.py in Plyer. Similarly we know that VibrationApp is the Main Application, and that build() returns the root widget, etc., without needing docstrings.) Also, remember to follow our standards (look at the rest of the code). We use '''''' for docstrings, not """""".
sync pull request
| def _exists(self): | ||
| if SDK_INT >= 11: | ||
| return vibrator.hasVibrator() | ||
| return NotImplementedError() |
There was a problem hiding this comment.
Please review this line.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
existsis supported only for android SDK >= 11. Rest features work.Tested on Samsung Galaxy I, android 2.3.
What we should do? Does we need new Exception
NotSupportedor just returnNoneCurrently it returns None if SDK < 11
best regards