Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip BOM character from string before performing XML transformation #5744

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

solth
Copy link
Member

@solth solth commented Aug 9, 2023

When importing metadata records from external sources or via file upload, the XML conversion fails if the imported XML starts with a UTF byte order mark (BOM) character with unicode code point \uFEFF. The change in this pull request checks the XML string for a leading BOM character and removes it before applying the XML transformation.

@solth solth added the bug label Aug 9, 2023
@solth solth requested a review from matthias-ronge August 14, 2023 12:36
@solth solth merged commit 54d7565 into kitodo:master Aug 16, 2023
@solth solth deleted the bom branch August 16, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants