Renames variables ending in "interface" because they hold an instance #5674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... of a class that implements an interface. Even if an object implements an interface, it's still an object and not an interface, so this naming is misleading. It fixes a bit of Javadoc as well, and eliminates an unnecessary call to the module loader every time a script is run, since the module was loaded when the class was instantiated.
solth
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames variables ending in "interface" because they hold an instance of a class that implements an interface. Even if an object implements an interface, it's still an object and not an interface, so this naming is misleading. It fixes a bit of Javadoc as well, and eliminates an unnecessary call to the module loader every time a script is run, since the module was loaded when the class was instantiated.