Avoid duplication of metadata groups while adding new metadata fields #5549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IkramMaalej
approved these changes
Feb 21, 2023
|
I have no idea why the Selenium tests are failing. They all pass in my local environment. |
BartChris
force-pushed
the
avoid_duplication_of_metadata_groups
branch
from
1d0f016 to
97b5e52
Compare
|
@BartChris please rebase against current master as your pull request is the next merge candidate. |
BartChris
force-pushed
the
avoid_duplication_of_metadata_groups
branch
from
97b5e52 to
ae84189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves 5484
As outlined in the issue: existing metadata groups are added twice to the list of metadata elements when new elements are added to the list. This PR addresses this by explicitely removing the metadata groups which have the empty elements filtered out before the existing groups are reconstructed from the tree (including their empty values).