Remove support for Travis use #5534
Conversation
henning-gerhardt
force-pushed
the
remove_travis_support
branch
from
f469c27 to
232842e
Compare
henning-gerhardt
force-pushed
the
remove_travis_support
branch
from
232842e to
05df98f
Compare
There was a problem hiding this comment.
Do you think it would be possible to adapt the implementation of MailSender to reuse it for Github CI instead of Travis instead of removing it? The files in question do seem to contain very little Travis specific code, so perhaps it would be possible to retain this useful functionality?
|
This could be possible but I don't know how to archive that. If somebody want to implant this functionality, feel free to re-use this code. I want to only remove unused code. |
|
I don't know if this functionality was really working or was only working for specific users. |
henning-gerhardt
force-pushed
the
remove_travis_support
branch
from
05df98f to
8b45e95
Compare
henning-gerhardt
force-pushed
the
remove_travis_support
branch
from
8b45e95 to
04b7ce6
Compare
|
It only worked partially for me - I did get screenshots send when a selenium test failed, but those sceenshots always only contained an white, empty browser window. So I guess it didn't really work. |
|
Famous last words: we switched from Travis CI to GitHub actions a long time ago and no one was complaining about this missing functionality. |
CI based on Travis is not anymore the use case, so remove the needed and used code for this usage.