Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Consistently use type declaration for parameters and return values - part 1 #1018

Merged
merged 5 commits into from
Sep 29, 2023
Merged

[MAINTENANCE] Consistently use type declaration for parameters and return values - part 1 #1018

merged 5 commits into from
Sep 29, 2023

Conversation

beatrycze-volk
Copy link
Collaborator

Change for #399

@beatrycze-volk beatrycze-volk force-pushed the type-declaration branch 21 times, most recently from 8fb7345 to ddf84fd Compare September 29, 2023 10:55
@sebastian-meyer sebastian-meyer mentioned this pull request Sep 29, 2023
Open
15 tasks
@sebastian-meyer sebastian-meyer self-requested a review September 29, 2023 12:17
@sebastian-meyer sebastian-meyer added the 🛠 maintenance A task to keep the code up-to-date and manageable. label Sep 29, 2023
@sebastian-meyer sebastian-meyer changed the title Consistently use type declaration for parameters and return values [MAINTENANCE] Consistently use type declaration for parameters and return values Sep 29, 2023
@beatrycze-volk beatrycze-volk marked this pull request as draft September 29, 2023 14:25
@beatrycze-volk beatrycze-volk force-pushed the type-declaration branch 13 times, most recently from 60e170e to 1830faf Compare September 29, 2023 16:21
@beatrycze-volk beatrycze-volk force-pushed the type-declaration branch 3 times, most recently from 37d8a98 to 7888ff8 Compare September 29, 2023 16:34
@beatrycze-volk beatrycze-volk marked this pull request as ready for review September 29, 2023 16:35
@beatrycze-volk
Copy link
Collaborator Author

The problem with OAI tests is related to some changes inside the Controller and Domain package, so I have taken those two back and will handle them in seprated PR. This one is now ready for review.

@beatrycze-volk beatrycze-volk changed the title [MAINTENANCE] Consistently use type declaration for parameters and return values [MAINTENANCE] Consistently use type declaration for parameters and return values - part 1 Sep 29, 2023
@sebastian-meyer sebastian-meyer merged commit aa77dc7 into kitodo:master Sep 29, 2023
@beatrycze-volk beatrycze-volk deleted the type-declaration branch October 4, 2023 08:37
@beatrycze-volk beatrycze-volk mentioned this pull request Oct 17, 2023
Merged
@BFallert BFallert mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-meyer sebastian-meyer sebastian-meyer approved these changes

Assignees

@beatrycze-volk beatrycze-volk

Labels
🛠 maintenance A task to keep the code up-to-date and manageable.
Projects
None yet
Milestone
Kitodo.Presentation 5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@beatrycze-volk @sebastian-meyer