Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): not record log message in span #38

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

CoderPoet
Copy link
Member

Background: To reduce the storage volume of spans, no longer need to record log bodies in spans

  • logrus
  • zap
  • slog

@CoderPoet CoderPoet requested a review from rogerogers January 17, 2024 04:18
Copy link
Collaborator

@rogerogers rogerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogerogers rogerogers merged commit 3c3938c into main Jan 17, 2024
14 checks passed
@rogerogers rogerogers deleted the fix/log-message branch January 17, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants