Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:integrating slog to obs #34

Merged
merged 10 commits into from
Dec 2, 2023
Merged

feat:integrating slog to obs #34

merged 10 commits into from
Dec 2, 2023

Conversation

XZ0730
Copy link
Member

@XZ0730 XZ0730 commented Nov 27, 2023

target

  • Complete the integration of slog into OBS

processing

  • readme
  • some test

li-jin-gou
li-jin-gou reviewed Nov 27, 2023
View reviewed changes
logging/slog/option.go Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou reviewed Nov 30, 2023
View reviewed changes
logging/slog/utils.go Outdated Show resolved Hide resolved
rogerogers
rogerogers reviewed Nov 30, 2023
View reviewed changes
logging/slog/go.mod Outdated Show resolved Hide resolved
rogerogers
rogerogers reviewed Nov 30, 2023
View reviewed changes
logging/slog/handler.go Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou reviewed Nov 30, 2023
View reviewed changes
logging/slog/go.mod Outdated Show resolved Hide resolved
@li-jin-gou
Copy link
Contributor

@XZ0730 https://github.com/kitex-contrib/obs-opentelemetry/blob/main/.github/workflows/pr-check.yml CI 的 go 版本调整到 1.21

rogerogers
rogerogers reviewed Nov 30, 2023
View reviewed changes
logging/slog/handler.go Show resolved Hide resolved
logging/slog/option.go Show resolved Hide resolved
logging/slog/utils.go Show resolved Hide resolved
logging/slog/logger.go Show resolved Hide resolved
@bytedance-oss-robot bytedance-oss-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rogerogers, XZ0730
To complete the pull request process, please assign coderpoet after the PR has been reviewed.
You can assign the PR to them by writing /assign @coderpoet in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@li-jin-gou li-jin-gou merged commit 833526b into kitex-contrib:main Dec 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-jin-gou li-jin-gou li-jin-gou left review comments

@rogerogers rogerogers rogerogers approved these changes

@CoderPoet CoderPoet Awaiting requested review from CoderPoet

Assignees

@li-jin-gou li-jin-gou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XZ0730 @li-jin-gou @rogerogers