Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[logging/zap]:Modify span status judgment #30

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

tianming244052
Copy link
Contributor

Modify span status judgment

Copy link
Member

@CoderPoet CoderPoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@bytedance-oss-robot bytedance-oss-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2023
@bytedance-oss-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CoderPoet, rogerogers, tianming244052

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bytedance-oss-robot bytedance-oss-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2023
@bytedance-oss-robot bytedance-oss-robot bot merged commit 7609332 into kitex-contrib:main Aug 19, 2023
@rogerogers rogerogers mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants