-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: print span info with ctx && add CtxKVLog method #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to sign cla
|
Please fix the problem with code formatting |
golangci-lint run --out-format=github-actions --path-prefix=./logging/zap -E gofumpt, it's ok |
Seems not necessary to introduce logger, zap.Any is even slower than sugar. |
I see https://github.com/uber-go/zap#performance performance is good to me; |
https://pkg.go.dev/go.uber.org/zap#hdr-Choosing_a_Logger sugar has similar methods. |
3q~, sugar **w method print kv log is ok~ |
@CoderPoet Seems that all issues are fixed. Please help to take a look at this pr, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CoderPoet, weedge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
go get go.opentelemetry.io/[email protected]
CHANGE: