Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modern image scales. #5

Merged
merged 11 commits into from
Jan 26, 2021
Merged

Add modern image scales. #5

merged 11 commits into from
Jan 26, 2021

Conversation

tisto
Copy link
Member

@tisto tisto commented May 2, 2020

No description provided.

tisto and others added 5 commits May 2, 2020 14:31
* master:
  black
  MANIFEST.in: exclude some files
  Back to development: 1.4.1
  Preparing release 1.4.0
  Run black on Travis
  Run travis.cfg
  Make update
  Add volto.preview_image behavior to Page type.
  Add volto.preview_image behavior to Page type
  Back to development: 1.3.3
  Preparing release 1.3.2
  Changelog
  Make sure that portal is portal
  Back to development: 1.3.2
  Preparing release 1.3.1
  Fix LRF global allow and ensure default behaviors
  Back to development: 1.3.1
  Preparing release 1.3.0
  Add missing transaction import
  Add PAM consistency script
@sneridagh
Copy link
Member

@tisto I tweaked it a bit, to make this optional, already been bitten by this several times.

* master:
  Back to development: 1.5.3
  Preparing release 1.5.2
  Missing translations ZCML registrations
  Back to development: 1.5.2
  Preparing release 1.5.1
  Add zest.pocompile
  Remove Travis badge
  Back to development: 1.5.1
  Preparing release 1.5.0
  Bye bye travis 2
  Revert "Bye bye travis"
  Bye bye travis
  GH actions
  Update to Plone 5.2.3
  Fix locales by default being in German
@tisto
Copy link
Member Author

tisto commented Dec 18, 2020

@sneridagh do you see a risk in applying those image sizes in existing projects? We could as well do a breaking release.

@sneridagh
Copy link
Member

@tisto I would initially make it opt-in, present it on Tuesday to the @plone/volto-team then make a breaking making it mandatory. Also, there is a initiative by @tiberiuichim for improve the scales and image conversions that we will discuss on Tuesday too.

* master:
  Back to development: 1.6.1
  Preparing release 1.6.0
  Added indexers for `preview_image`, it allows the Volto object browser widget to access it
* master:
  Add README
  Add breadcrumbs_view override to include nav_title
* master:
  Back to development: 1.7.1
  Preparing release 1.7.0
@sneridagh sneridagh changed the title [WIP] Add modern image scales. Add modern image scales. Jan 21, 2021
@sneridagh
Copy link
Member

sneridagh commented Jan 21, 2021

@plone/volto-team These are the scales that we mentioned on the last meeting:

    <element>icon 32:32</element>
    <element>tile 64:64</element>
    <element>thumb 128:128</element>
    <element>mini 200:65536</element>
    <element>preview 400:65536</element>
    <element>teaser 600:65536</element>
    <element>large 800:65536</element>
    <element>larger 1000:65536</element>
    <element>great 1200:65536</element>
    <element>huge 1600:65536</element>     

they will override Plone's existing ones, if you want to define your own, then you should apply yours after applying this profile.

What do you think? Do you feel that there's some scales you are using missing?

I would not bloat it much more anyways, since the scales are created on save (all of them) this is something that Plone itself should fix at some point. Also, if we move from using Plone scales will be much better, but as a first step, we should define them.

BTW, I will release a 2.0.0 (breaking) version with this one.

Also, we will PLIP this for include it in upcoming Plone releases when we reach an agreement.

@sneridagh sneridagh merged commit ec95f4d into master Jan 26, 2021
@sneridagh sneridagh deleted the image-scales branch January 26, 2021 18:42
tisto pushed a commit that referenced this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants