Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix no penalty for penalty < 1 #144

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix no penalty for penalty < 1 #144

merged 2 commits into from
Nov 14, 2024

Conversation

Feuermagier
Copy link
Collaborator

Since penalty was an integer for stacking penalties, every penalty < 1.0 was rounded to 0.0

@Feuermagier Feuermagier self-assigned this Nov 14, 2024
@Feuermagier Feuermagier requested a review from a team as a code owner November 14, 2024 08:29
@Feuermagier
Copy link
Collaborator Author

@uuqjz

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

uuqjz
uuqjz approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@uuqjz uuqjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uuqjz uuqjz merged commit 57c84b6 into main Nov 14, 2024
5 checks passed
@uuqjz uuqjz deleted the stacking-penalty branch November 14, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uuqjz uuqjz uuqjz approved these changes

@Luro02 Luro02 Luro02 approved these changes

Assignees

@Feuermagier Feuermagier

Labels
None yet
Projects
Artemis & Programming
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Feuermagier @Luro02 @uuqjz