Fix dates (without times) and times (without dates) #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found two separate but related problems, the first is a date without a time (fixed by adding
datetime.date
to theJSONDateTimeEncoder
; the second a time without a date, which yaml refers to as a sexagesimal. YAML 1.1 specifies that these parse as base 60 integers, and can't easily be round-tripped. I fixed that by switching to an api-compatible yaml loader that supports yaml 1.2, which eliminates sexagesimals among other things.