Change exemplars to slice of values instead of ptrs (#2402)

Benchmarks before: ``` goos: darwin goarch: amd64 pkg: go.opentelemetry.io/collector/consumer/pdata BenchmarkMetricsFromOtlp BenchmarkMetricsFromOtlp-16 322 3809358 ns/op 2271080 B/op 51507 allocs/op PASS ``` Benchmarks after ``` goos: darwin goarch: amd64 pkg: go.opentelemetry.io/collector/consumer/pdata BenchmarkMetricsFromOtlp BenchmarkMetricsFromOtlp-16 331 3594315 ns/op 3212271 B/op 34700 allocs/op PASS ``` Significant improvement in the number of allocations. Increase in the number of total bytes allocated. Signed-off-by: Bogdan Drutu <[email protected]>
kisieland · Feb 3, 2021 · 522fba3 · 522fba3
1 parent e12dee4
commit 522fba3
Show file tree

Hide file tree

Showing 7 changed files with 149 additions and 145 deletions.
diff --git a/cmd/pdatagen/internal/metrics_structs.go b/cmd/pdatagen/internal/metrics_structs.go
@@ -340,7 +340,7 @@ var quantileValues = &messageValueStruct{
 	},
 }
 
-var intExemplarSlice = &sliceOfPtrs{
+var intExemplarSlice = &sliceOfValues{
 	structName: "IntExemplarSlice",
 	element:    intExemplar,
 }
@@ -363,7 +363,7 @@ var intExemplar = &messageValueStruct{
 	},
 }
 
-var doubleExemplarSlice = &sliceOfPtrs{
+var doubleExemplarSlice = &sliceOfValues{
 	structName: "DoubleExemplarSlice",
 	element:    doubleExemplar,
 }

diff --git a/consumer/pdata/generated_metrics.go b/consumer/pdata/generated_metrics.go
diff --git a/consumer/pdata/generated_metrics_test.go b/consumer/pdata/generated_metrics_test.go
diff --git a/consumer/simple/metrics_test.go b/consumer/simple/metrics_test.go
@@ -123,7 +123,8 @@ func TestMetrics(t *testing.T) {
                       }
                     ],
                     "time_unix_nano": 1597266546570840817,
-                    "value": 9000000
+                    "value": 9000000,
+                    "exemplars": null
                   }
                 ]
               }
@@ -142,7 +143,8 @@ func TestMetrics(t *testing.T) {
                       }
                     ],
                     "time_unix_nano": 1597266546570840817,
-                    "value": 50
+                    "value": 50,
+                    "exemplars": null
                   },
                   {
                     "labels": [
@@ -156,7 +158,8 @@ func TestMetrics(t *testing.T) {
                       }
                     ],
                     "time_unix_nano": 1597266546570840817,
-                    "value": 5
+                    "value": 5,
+                    "exemplars": null
                   }
                 ]
               }
@@ -175,7 +178,8 @@ func TestMetrics(t *testing.T) {
                       }
                     ],
                     "time_unix_nano": 1597266546570840817,
-                    "value": 30.5
+                    "value": 30.5,
+                    "exemplars": null
                   }
                 ]
               }
@@ -194,7 +198,8 @@ func TestMetrics(t *testing.T) {
                       }
                     ],
                     "time_unix_nano": 1597266546570840817,
-                    "value": 100.6
+                    "value": 100.6,
+                    "exemplars": null
                   }
                 ]
               }
@@ -217,7 +222,8 @@ func TestMetrics(t *testing.T) {
                       }
                     ],
                     "time_unix_nano": 1597266546570840817,
-                    "value": 40000
+                    "value": 40000,
+                    "exemplars": null
                   }
                 ]
               }
@@ -230,7 +236,8 @@ func TestMetrics(t *testing.T) {
                 "data_points": [
                   {
                     "labels": [],
-                    "time_unix_nano": 1597266546570840817
+                    "time_unix_nano": 1597266546570840817,
+                    "exemplars": null
                   }
                 ]
               }
@@ -243,7 +250,8 @@ func TestMetrics(t *testing.T) {
                 "data_points": [
                   {
                     "labels": [],
-                    "time_unix_nano": 1597266546570840817
+                    "time_unix_nano": 1597266546570840817,
+                    "exemplars": null
                   }
                 ]
               }