Create ImageBox.thumbnail when ImageBox.image is being set #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This closes #357 , in which it's described how a recipe cannot be modified, because of a save error when serializing the image and its thumbnail.
The problem is that the thumbnail attribute was only created when loading an image from file, and not when loading the image from bytes (ie. from the database.)
This resolves the issue by moving the thumbnail creation to whenever the image is loaded.
How Has This Been Tested?
This was tested by editing the title of a recipe (
Hong Kong ice cream
->Hong-Kong ice cream
).Without the changes, an AttributeError is raised.
With the changes, the application behaves as expected.
Screenshots (if appropriate):
Types of changes
Checklist: