Fix file chooser dialog on recipe export #347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #346 where it's described how recipes cannot be exported.
This was due to a bug in the interface between the file selector window, which returned only a list of filename(s), and the logic later that was expecting an extension to look up the correct plugin.
Now, the extension is directly provided, looked-up from the filetype combobox in the file chooser dialog.
How Has This Been Tested?
This was tested by:
The combo box gets updated when typing another valid extension. That is, if
recipe.invalid
is provided,then the file type is inferred from the combo box.
If the filename is set to
recipe.txt
, then the combo box gets updated automatically, and its value is used, as above.Ok
button, which simplifies the input validation.None, None
to the export manager.Screenshots (if appropriate):
Types of changes
Checklist: