New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean CI #177

Merged

cydanil merged 2 commits into kirienko:master from cydanil:clean/remove_build_icon

Sep 10, 2020

Collaborator

cydanil commented Sep 10, 2020

This PR does two things:

Publish the wheel artifact with the commit id it was created from. With this, we'll be able to share changes and track where they come from.
Remove the build_icon from setup.py: it turned out that it does nothing anymore!

cydanil added 2 commits

September 10, 2020 18:09


          Remove deprecated build_icon from setup

4a76754


          CI: Publish wheel with commit id

Collaborator Author

cydanil commented Sep 10, 2020

Here's an example:

Go to https://github.com/kirienko/gourmet/pull/177/checks?check_run_id=1097526715 , where you'll notice an Artifacts drop-down button.
Download it and unzip it.
You'll find a file gourmet-ff91ac95-py3-none-any.whl (yeah, that's the commit id 😎)
Do a pip install --upgrade gourmet-ff91ac95-py3-none-any.whl (notice how it's not in edit mode!)
Then launch it: gourmet !

cydanil merged commit dd2591b into kirienko:master

cydanil deleted the clean/remove_build_icon branch

September 10, 2020 16:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet