Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding New Recipe Does Not Update Index Properly #228

Closed
zombiewoof opened this issue Oct 3, 2020 · 3 comments
Closed

Adding New Recipe Does Not Update Index Properly #228

zombiewoof opened this issue Oct 3, 2020 · 3 comments
Labels
Milestone

Comments

@zombiewoof
Copy link

When adding new recipe, index is incorrectly updated. Behavior differs if viewing last index page vs any other, as described below.

Choose Add Recipe when viewing any index page, except the last. When new recipe is saved, use the Last button to go to the last index page. New entry does not display name or thumbnail and cuisine, rating and source are missing. Screenshot shows this and the result of double-clicking the new recipe (display of edit window instead of recipe card).

Gourmet add recipe 1 2020-10-03 11-29-32

When same test is run while viewing the last index page, the new recipe does not show up until the Last button is clicked. Again, the index is incorrectly updated, as before. However, the previous test recipe shows up correctly, now. Screenshot shows this and the result of double-clicking the new recipe (display of edit window instead of recipe card).

Gourmet add recipe 2 2020-10-03 11-44-48

Environment

gourmet-5ad618be
Operating System: Ubuntu 20.04 (with latest updates)
Desktop: Cinnamon 4.4.8
Installed as Flatpak

@cydanil cydanil added the bug label Oct 3, 2020
@cydanil cydanil added this to the alpha 2 milestone Oct 3, 2020
@cydanil
Copy link
Collaborator

cydanil commented Oct 3, 2020

Thanks, this is a confirmation of #196 and thinkle/issues/962 .
Since this ticket has the most infos, I'm closing the other ticket.

@zombiewoof
Copy link
Author

You should note that this behavior is slightly different to the python2 version of Gourmet. In that version, if you are on the last index page, the new recipe is added to the index correctly. If one is on another index page, when adding, the same behavior as reported for python3 version occurs.

@cydanil
Copy link
Collaborator

cydanil commented Oct 5, 2020

Thanks!
Just like #227 , this was caused by changes in the [hide method](https://github.com/kirienko/gourmet/pull/132/files#diff-f8ba652dac21fa98c3f63d5592c79174R134-R140) modified in PR #132.

This was fixed in #235 .

@cydanil cydanil closed this as completed Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants