-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Kirby Slides design #2949
New Kirby Slides design #2949
Conversation
9a2e349
to
2529404
Compare
8763901
to
1ae8311
Compare
4b27646
to
40fbfbb
Compare
Comments:
|
This module isn't exported through |
fd0b598
to
61df7e0
Compare
border-radius: 2px; | ||
} | ||
|
||
div.pagination span.swiper-pagination-bullet:last-of-type { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whis looks more like it should be placed in the carrousel
component styling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally agree, but for some reason I cannot make it work if I place the styling in carousel.component.scss
. It's not because the styling is overridden, but more like it is never applied to the bullet span
elementens. Do you have any ideas what the problem could be @RasmusKjeldgaard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mark-drastrup this is due to Angular style encapsulation. Your span selector will be augmented with _ngcontent-xxx
attribute which the bullets don't have as they are added to the dom by swiperjs. This can be fixed by using ::ng-deep
on the selector in the component scss - as in:
.pagination ::ng-deep span.swiper-pagination-bullet:last-of-type { ... }
apps/cookbook/src/app/examples/carousel-example/carousel-code-snippets.ts
Outdated
Show resolved
Hide resolved
apps/cookbook/src/app/examples/carousel-example/carousel-code-snippets.ts
Outdated
Show resolved
Hide resolved
apps/cookbook/src/app/examples/carousel-example/carousel-code-snippets.ts
Outdated
Show resolved
Hide resolved
apps/cookbook/src/app/examples/carousel-example/carousel-example.component.html
Outdated
Show resolved
Hide resolved
29e604f
to
6587fd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two docs-related things from me on this one!
Which issue does this PR close?
This PR closes #1986
What is the new behavior?
A new carousel component based on Swiper.js. This component will replace the exisiting slides component.
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.