HDFS-15882. Fix incorrectly initializing RandomAccessFile based on co…

…nfiguration options (apache#2751). Contributed by Xie Lei. Reviewed-by: He Xiaoqiao <[email protected]>
kiran-maturi · Nov 24, 2021 · b5ffc0d · b5ffc0d
1 parent 44df69e
commit b5ffc0d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...op-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogFileOutputStream.java b/...op-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EditLogFileOutputStream.java
@@ -84,9 +84,9 @@ public EditLogFileOutputStream(Configuration conf, File name, int size)
     doubleBuf = new EditsDoubleBuffer(size);
     RandomAccessFile rp;
     if (shouldSyncWritesAndSkipFsync) {
-      rp = new RandomAccessFile(name, "rws");
-    } else {
       rp = new RandomAccessFile(name, "rw");
+    } else {
+      rp = new RandomAccessFile(name, "rws");
     }
     fp = new FileOutputStream(rp.getFD()); // open for append
     fc = rp.getChannel();