-
Notifications
You must be signed in to change notification settings - Fork 35
scripts: introduce configurable number of load gen threads #6
scripts: introduce configurable number of load gen threads #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't run it, but seems OK. I left some comments with potential improvements.
This change reverts setting new default values, incorporating feedback received in PR #6. The "sane" default values will be discussed in a separate, future PR. Signed-off-by: Thilo Fromm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like changing values back end forth in a scope of single PR. I'd squash all commits and update it's message, so we have clear history of master branch.
e2883d7
to
69ecd86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last commit. Other than that LGTM, though I didn't test.
This change adds support for a --threads flag to wrk2/render.sh, and adds the number of benchmark load generator threads to benchmark.sh and benchmark-multi.sh. Signed-off-by: Thilo Fromm <[email protected]>
69ecd86
to
494c0e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I didn't test it. I'm going to do it now, but it should be good to merge.
This change adds support for a --threads flag to
wrk2/render.sh
, andadds the number of benchmark load generator threads to
benchmark.sh
and
benchmark-multi.sh
.Signed-off-by: Thilo Fromm [email protected]