Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

scripts: introduce configurable number of load gen threads #6

Merged

Conversation

t-lo
Copy link
Member

@t-lo t-lo commented May 19, 2019

This change adds support for a --threads flag to wrk2/render.sh, and
adds the number of benchmark load generator threads to benchmark.sh
and benchmark-multi.sh.

Signed-off-by: Thilo Fromm [email protected]

@t-lo t-lo requested a review from invidian May 20, 2019 13:54
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run it, but seems OK. I left some comments with potential improvements.

scripts/istio/benchmark.sh Show resolved Hide resolved
README.md Show resolved Hide resolved
scripts/istio/benchmark-multi.sh Outdated Show resolved Hide resolved
scripts/istio/benchmark.sh Outdated Show resolved Hide resolved
scripts/linkerd/benchmark-multi.sh Outdated Show resolved Hide resolved
scripts/linkerd/benchmark.sh Outdated Show resolved Hide resolved
t-lo added a commit that referenced this pull request May 27, 2019
This change reverts setting new default values, incorporating feedback
received in PR #6. The "sane" default values will be discussed in a
separate, future PR.

Signed-off-by: Thilo Fromm <[email protected]>
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like changing values back end forth in a scope of single PR. I'd squash all commits and update it's message, so we have clear history of master branch.

@t-lo t-lo force-pushed the t-lo/configure-nr-of-threads-independent-of-nr-of-instances branch from e2883d7 to 69ecd86 Compare May 27, 2019 11:21
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last commit. Other than that LGTM, though I didn't test.

scripts/common.sh Outdated Show resolved Hide resolved
This change adds support for a --threads flag to wrk2/render.sh, and
adds the number of benchmark load generator threads to benchmark.sh
and benchmark-multi.sh.

Signed-off-by: Thilo Fromm <[email protected]>
@t-lo t-lo force-pushed the t-lo/configure-nr-of-threads-independent-of-nr-of-instances branch from 69ecd86 to 494c0e4 Compare May 27, 2019 11:33
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I didn't test it. I'm going to do it now, but it should be good to merge.

@t-lo t-lo merged commit 7bce770 into master May 27, 2019
@t-lo t-lo deleted the t-lo/configure-nr-of-threads-independent-of-nr-of-instances branch May 27, 2019 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants