-
Notifications
You must be signed in to change notification settings - Fork 48
Conversation
e6fceea
to
5e6659e
Compare
5e6659e
to
ecb0fff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits, otherwise LGTM.
I wonder if we could have some e2e test to ensure that this detector is doing it's thing and has privileges to modify Node object etc.
test/components/node-problem-detector/node_problem_detector_test.go
Outdated
Show resolved
Hide resolved
4840333
to
48184bf
Compare
Updated the PR, writing e2e test, to test the working of component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we could squash almost everything into single commit. Maybe we could keep asset import in a separate one, as it's a lot of files.
48184bf
to
88efcb9
Compare
8206269
to
3cf6629
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And do we have a way of testing custom monitors? Did you test it @knrt10 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this integrating with the prometheus stack?
I am trying to understand once this is installed now what? How does the user get any alerts?
3cf6629
to
7a4854c
Compare
@surajssd the component has |
10611af
to
4ff9aff
Compare
test/components/node-problem-detector/nodeproblemdetector_test.go
Outdated
Show resolved
Hide resolved
This adds component node-problem-detector. For more information refer to https://github.com/kubernetes/node-problem-detector. closes: #39 Signed-off-by: knrt10 <[email protected]>
Signed-off-by: knrt10 <[email protected]>
Signed-off-by: knrt10 <[email protected]>
4ff9aff
to
7fce619
Compare
7fce619
to
b7e1bcb
Compare
Signed-off-by: knrt10 <[email protected]>
b7e1bcb
to
ae9271a
Compare
We can test that this metric can be scraped via e2e tests then. |
Signed-off-by: knrt10 <[email protected]>
This add monitoring test for node-problem-detector component. Signed-off-by: knrt10 <[email protected]>
ae9271a
to
99d4024
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
This adds component node-problem-detector. For more information
refer to https://github.com/kubernetes/node-problem-detector.
closes: #39
Signed-off-by: knrt10 [email protected]
TODO
How to use
Pass the following in your cluster config. To use
service_monitor
feature, make sure Prometheus Operator component is installed