-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expand on alternatives that were considered and rejected for sidecars #1
expand on alternatives that were considered and rejected for sidecars #1
Conversation
Co-Authored-By: Bob Killen <[email protected]>
5265858
to
e642a9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Joseph-Irving Thanks a lot, this is really useful! Do you think you can find a link to where the decision was taken (like comments on github, etc.) for each of the alternatives?
Added a few suggestions to make alternatives titles more descriptive, let me know what you think
I can find some of the comments on github discussing some of these things, however, if you want some kind of record of a definitive decision being made on each of these alternatives that probably doesn't exist. The decision was made when the KEP approvers from Sig-apps and Sig-node approved the KEP and allowed it to be merged, so there's no record of them rejecting the alternatives only of them accepting the current proposal. Also just because something did get rejected earlier doesn't mean it never gets discussed again. I've had the same conversation with many people about the same things often reaching the same conclusion. Perhaps if we started something like this from the beginning that would've at least helped to reduce endless debates on the same topic. |
@Joseph-Irving I think those links might help, and maybe we can add what you say here too: We added some links to where part of the discussion happened and mention that there are no records of some alternatives and the discussions were repeated arriving to the same conclusions, and we hope that adding this section would at least give some context to the reader and save time if we will arrive to the same conclusion. What do you think? |
I added all the links I could find, I may have missed something, there's a lot of discussion spread over many PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot @Joseph-Irving ! :)
Capture implementation details of enabling smtaware CPU Manager policy
chore: add sequence diagram for encrypt and decrypt request
Structured Authentication Config KEP Updates
Here's my first pass at expanding this section, let me know what you think