This repository has been archived by the owner on May 6, 2020. It is now read-only.
kubelet: Close health port in kubelet bootstrap pods #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajssd
force-pushed
the
surajssd/close-health-port
branch
3 times, most recently
from
491cc3d to
9283a5e
Compare
invidian
force-pushed
the
surajssd/close-health-port
branch
from
9283a5e to
a4e4f9c
Compare
|
Pushed to trigger CI. |
iaguis
previously approved these changes
Feb 18, 2020
iaguis
force-pushed
the
surajssd/close-health-port
branch
from
a4e4f9c to
c6ec3bf
Compare
* This port is not used in Lokomotive for anything, so rather close it. Signed-off-by: Suraj Deshmukh <[email protected]>
invidian
force-pushed
the
surajssd/close-health-port
branch
from
c6ec3bf to
19e0b6e
Compare
|
Resolved conflicts. |
Signed-off-by: Suraj Deshmukh <[email protected]>
invidian
force-pushed
the
surajssd/close-health-port
branch
from
19e0b6e to
729f822
Compare
|
Kubelet listens on 127.0.0.1 by default, which I'm not sure is right for health checks, so let's try with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add livenessProbe and readinessProbe to self hosted kubelet.