Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented support for testplan custom fields values obtaining #60

Merged
merged 1 commit into from
Apr 8, 2016

Conversation

maiksaray
Copy link

Implemented support for testplan custom fields

This was needed to integrate jenkins with testlink in a more elegant way

@kinow
Copy link
Owner

kinow commented Apr 8, 2016

Just confirmed in 1.9.14 that the method getTestPlanCustomFieldDesignValue is available in the XML-RPC API.

@kinow
Copy link
Owner

kinow commented Apr 8, 2016

There are a few parameters missing. The getTestPlanCustomFieldDesignValue method in the PHP API calls the getCustomFieldValue internal method.

This last method receives:

  • scopeParamName ("scope") (set by the getTestPlanCustomFieldDesignValue with 'design' value)
  • testPlanIDParamName ("testplanid")
  • testProjectIDParamName ("testprojectid")
  • customFieldNameParamName ("customfieldname")
  • nodeTypeParamName ("nodetype") (set by the getTestPlanCustomFieldDesignValue with 'testplan' value)
  • nodeIDParamName ("nodeid")
  • executionIDParamName ("executionid")
  • linkIDParamName ("linkid")

But if the method works without the other parameters, let's add it anyway and we will add the remaining parameters another time.

@@ -24,6 +24,8 @@
package br.eti.kinoshita.testlinkjavaapi.model;

import java.io.Serializable;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Will bump the serialVersionUID too as the TestPlan constructor and properties changed. Kudos!

@kinow
Copy link
Owner

kinow commented Apr 8, 2016

Looking good! Merging.

@kinow kinow merged commit bd0cd4f into kinow:master Apr 8, 2016
@maiksaray
Copy link
Author

Thanks for the attitude! Are you going to update version in mvn repo soon?

@maiksaray maiksaray deleted the testplan-customfields branch April 8, 2016 09:51
@kinow
Copy link
Owner

kinow commented Apr 8, 2016

Scheduled for Sunday noon New Zealand time -

<release version="1.9.14-0" date="2016-04-10" description="1.9.14-0 release">

Should happen on Sunday, or in case I don't have spare time on Sunday, definitely Monday evening.

@maiksaray
Copy link
Author

Oh, many thanks to you, sorry for not finding it on my own

@kinow
Copy link
Owner

kinow commented Apr 8, 2016

Not a problem, just committed that moments ago 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants