Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't embed 2d points in (yz-plane of) 3d, fixes #60 #63

Merged
merged 1 commit into from
Oct 2, 2018
Merged

don't embed 2d points in (yz-plane of) 3d, fixes #60 #63

merged 1 commit into from
Oct 2, 2018

Conversation

gdmcbain
Copy link
Contributor

@gdmcbain gdmcbain commented Oct 2, 2018

Calling Mesh2d.save used to embed the points in the yz-plane #60; however, skipping this (as implemented here) lets meshio.write embed the points in the xy-plane for VTK output (three dimensions being required by that format) or output valid two-dimensional meshes in formats that allow that, e.g. MEDIT mesh.

meshio.vtk_io.write does emit a warning

WARNING:root:VTK requires 3D points, but 2D points given. Appending 0 third component.

but it's harmless.

@kinnala kinnala merged commit 167ba29 into kinnala:master Oct 2, 2018
@gdmcbain gdmcbain deleted the dont-imbed-60 branch October 2, 2018 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants