Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ElementHex2 #468

Merged
merged 13 commits into from
Sep 14, 2020
Merged

Add ElementHex2 #468

merged 13 commits into from
Sep 14, 2020

Conversation

kinnala
Copy link
Owner

@kinnala kinnala commented Sep 12, 2020

Here is some work-in-progress how ElementHex2 could look like (not fully working yet I'm afraid). There are some optimizations possible, but I need to measure it first. Closes #327 when ready.

@kinnala
Copy link
Owner Author

kinnala commented Sep 13, 2020

hexa2
Something's wrong, most likely ordering of the DOF's.

@kinnala
Copy link
Owner Author

kinnala commented Sep 13, 2020

I'm slightly confused that none of the unit tests catch this issue and only the convergence test fails.

@kinnala
Copy link
Owner Author

kinnala commented Sep 13, 2020

Yeah, had doflocs in the wrong order. 🤦

@kinnala
Copy link
Owner Author

kinnala commented Sep 13, 2020

I'm now wondering if this way of constructing the basis should be a general strategy: start with ElementGlobal on the reference element and then transform that into ElementH1.

@kinnala
Copy link
Owner Author

kinnala commented Sep 14, 2020

I'll leave it like this for now; now that the tests exist and the implementation is correct, we can optimize it later if needed.

@kinnala kinnala merged commit cf826f6 into master Sep 14, 2020
@kinnala kinnala deleted the add-elementhex2 branch March 13, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElementHex2
1 participant