Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20 node quadratic hexahedral element #377

Merged
merged 22 commits into from
May 27, 2020
Merged

20 node quadratic hexahedral element #377

merged 22 commits into from
May 27, 2020

Conversation

kinnala
Copy link
Owner

@kinnala kinnala commented May 23, 2020

This begins the work on #327 .

Edit: Includes also a feature for merging two meshes via __add__.

@kinnala
Copy link
Owner Author

kinnala commented May 23, 2020

The convergence rate seems to be lower than I expect; I'm not sure what causes this. Need to investigate a bit further. Most likely an error in the implementation.

@kinnala
Copy link
Owner Author

kinnala commented May 25, 2020

Added several new tests but couldn't find the culprit: still the new element converges as O(h^1/2) in H^1 norm and O(h) in L^2 norm which isn't O(h^2) and O(h^3) as I'd expect.

@kinnala
Copy link
Owner Author

kinnala commented May 26, 2020

Figured out that there could still be a hidden bug in the facet->edge expansion. Added a test in the latest commit.

@kinnala
Copy link
Owner Author

kinnala commented May 26, 2020

Yes! Figured it out. The facet->edge expansion that was fixed in #83 was working only in case of tetrahedral elements.

@kinnala
Copy link
Owner Author

kinnala commented May 26, 2020

Now we have the first quadratic hexahedral element. Do we still need the 27 node element? Maybe for Stokes?

@kinnala kinnala changed the title Start work on quadratic serendipity hexahedron 20 node quadratic hexahedral element May 26, 2020
@kinnala kinnala requested a review from gdmcbain May 26, 2020 17:59
skfem/element/element_hex/element_hex_s2.py Show resolved Hide resolved
skfem/element/element_hex/element_hex_s2.py Outdated Show resolved Hide resolved
@gdmcbain
Copy link
Contributor

Do we still need the 27 node element? Maybe for Stokes?

Well we probably want it for completeness anyway and yes for Stokes, I think. ElementHex2 is often recommended for Stokes (e.g. Ern & Guermond 2004, Theory and Practice of Finite Elements, figure. 4.4), but I don't think I've seen serendipity elements used for incompressible fluids.

@kinnala
Copy link
Owner Author

kinnala commented May 27, 2020

Well we probably want it for completeness anyway and yes for Stokes, I think.

Sure. That can be my next follow up task.

@kinnala kinnala merged commit 045f3b3 into master May 27, 2020
@kinnala kinnala deleted the hexs2 branch August 7, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants