-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slider Responsiveness #72
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Sumit Verma <[email protected]>
Can you please use the latest version from the repo and include your feature request @smt96700 |
I have updated my feature request and ensured compatibility with the latest version of the repository; please review the changes and feel free to suggest any improvements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly look into the project section close buttons. Your feature request is not responding as it is tampered with in your base. Rest assured, other features are working pretty cool.
onClick={() => props?.setIsModalOpen(false)} | ||
onClick={() => props?.onClose()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have replaced incorrect setIsModalOpen with onClose function to resolve modal close functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, There is some issue of touch sensitivity in mobile view that they cannot scroll down and if they try the page changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it will review it soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've refined the slider's responsiveness for an enhanced mobile experience. Please review the changes.
Could you please review the pr I have updated my local branch with the current version of the main branch. |
Adjusted the responsive behavior of the slider component to improve usability on mobile devices.