Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider Responsiveness #72

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Conversation

smt96700
Copy link
Contributor

Adjusted the responsive behavior of the slider component to improve usability on mobile devices.

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 9:49am

@kingsmen732
Copy link
Owner

Can you please use the latest version from the repo and include your feature request @smt96700

@smt96700
Copy link
Contributor Author

I have updated my feature request and ensured compatibility with the latest version of the repository; please review the changes and feel free to suggest any improvements.

Copy link
Owner

@kingsmen732 kingsmen732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly look into the project section close buttons. Your feature request is not responding as it is tampered with in your base. Rest assured, other features are working pretty cool.

Comment on lines -22 to +23
onClick={() => props?.setIsModalOpen(false)}
onClick={() => props?.onClose()}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have replaced incorrect setIsModalOpen with onClose function to resolve modal close functionality.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, There is some issue of touch sensitivity in mobile view that they cannot scroll down and if they try the page changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it will review it soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've refined the slider's responsiveness for an enhanced mobile experience. Please review the changes.

@smt96700
Copy link
Contributor Author

Could you please review the pr I have updated my local branch with the current version of the main branch.

@kingsmen732 kingsmen732 merged commit b46b789 into kingsmen732:main Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants