Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crystal v1.0.0 enum compat #19

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Crystal v1.0.0 enum compat #19

merged 1 commit into from
Mar 23, 2021

Conversation

caspiano
Copy link
Collaborator

Enums serialise to strings by default as of 1.0.0 (see #10431).
This PR maintains backwards-compatibility.

Enums serialise to strings by default as of 1.0.0
This is a backwards compatible PR.
@caspiano caspiano requested a review from kingsleyh March 23, 2021 07:00
@caspiano caspiano self-assigned this Mar 23, 2021
Copy link
Contributor

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caspiano caspiano merged commit e00df1a into master Mar 23, 2021
@caspiano caspiano deleted the chore/crystal-1.0.0 branch March 23, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants