Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should :wx dependency be required? #43

Closed
mayel opened this issue Oct 20, 2024 · 7 comments
Closed

should :wx dependency be required? #43

mayel opened this issue Oct 20, 2024 · 7 comments

Comments

@mayel
Copy link

mayel commented Oct 20, 2024

This is causing me issues when trying to mix release in a docker that doesn't have or need wx

@kipcole9
Copy link
Collaborator

kipcole9 commented Oct 20, 2024

I didn't reaklise that :extra_applications propagated to consuming apps. You're right, it shouldn't be a hard requirement. I'll work out a way to add it only if it's present. I assume that's your primary symptom - wx isn't compiled into your production runtime?

@mayel
Copy link
Author

mayel commented Oct 20, 2024

That's right, I got (Mix) Could not find application :wx when running mix release after upgrading tz_world (in a docker build using hexpm's latest alpine-based image).

@kipcole9
Copy link
Collaborator

I've pushed a commit to have :wx and :observer included in :extra_applications only if they exist in the runtime. Would you consider given it a spin before I release? Configure with {:tz_world, github: "kipcole9/tz_world"}.

@mayel
Copy link
Author

mayel commented Oct 20, 2024

sure, on it!

@mayel
Copy link
Author

mayel commented Oct 20, 2024

that worked 👍

@kipcole9
Copy link
Collaborator

kipcole9 commented Oct 20, 2024 via email

@kipcole9
Copy link
Collaborator

I've published tz_world version 1.4.1 with he following changelog entry:

Bug Fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants