Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging ts in plugins #2

Closed
Closed
Changes from 1 commit
Commits
Show all changes
166 commits
Select commit Hold shift + click to select a range
2f23303
Children of buttons won't capture hover events in firefox (#13015)
stacey-gammon Jul 24, 2017
37fc949
Should only fit on shapes that are part of the result (#12881)
thomasneirynck Jul 24, 2017
190cd5f
Fixes #12602 - Change TSVB Fields API to use fieldCaps API (#12611)
simianhacker Jul 24, 2017
90c713f
Remove translations from management section (#13049)
epixa Jul 24, 2017
e676668
Branching for 6.0: bump version to 7.0.0-alpha1
jpfxgood Jul 24, 2017
89c7456
[Management] Provide a way to fetch index pattern titles (#13030)
chrisronline Jul 24, 2017
bdaf848
Move eslint-config-kibana into core (#12725)
kimjoar Jul 25, 2017
ce8333b
override version until elastic/elasticsearch#25876 is merged
spalger Jul 25, 2017
95d3a37
Remove premature abstraction (#13042)
chrisronline Jul 25, 2017
c8848a4
remove inline awaits (#13043)
stacey-gammon Jul 25, 2017
460157d
Updates esArchiver mappings to use single type (#13107)
tylersmalley Jul 25, 2017
008cf03
Plugin installer proxy support (#12753)
timroes Jul 26, 2017
fbec367
skip flaky discover test (#13114)
stacey-gammon Jul 26, 2017
b3ffd99
Add linting rules for formatting JSX. (#12810)
cjcenizal Jul 26, 2017
fa302a1
ensure timezone attribute in tests is adhered to (#13121)
stacey-gammon Jul 26, 2017
e77e64b
Removed _default_ from esArchiver test and updates data.json (#13122)
tylersmalley Jul 26, 2017
1675529
Make 'time picker' button in Discover no results prompt keyboard and …
cjcenizal Jul 26, 2017
e3aeb0b
Update filter editor docs with addition of advanced option (#13084)
lukasolson Jul 26, 2017
dd8c1ab
date_histogram: some bars are too big (#13068)
nreese Jul 27, 2017
e922f00
Upgrade eslint config to 0.8.1. (#13128)
cjcenizal Jul 27, 2017
8d5eac9
esvm: use branch from package.json (#13149)
epixa Jul 27, 2017
589df61
Stabilize and bring back flaky tests (#13034)
stacey-gammon Jul 27, 2017
2bee8bb
Add unit tests the verify correct `dataType` in `jQuery.ajax` request…
azasypkin Jul 27, 2017
9b949a5
Save layer setting in the region map UI (#12956)
thomasneirynck Jul 27, 2017
5e9a4ec
Region map should respect saved center and zoom (#12883)
thomasneirynck Jul 27, 2017
3884d38
[eslint-config-kibana] Add jest plugin and settings (#13090)
weltenwort Jul 28, 2017
fbd9fd0
fix metric default color (#12993)
ppisljar Jul 28, 2017
1e6ce85
adding docs for goal and gauge (#13140)
ppisljar Jul 28, 2017
3f54e94
Remove try/catch for short url so the appropriate errors will be prop…
stacey-gammon Jul 28, 2017
d14da34
Fix typos and punctuation in WMS settings (#13146)
timroes Jul 28, 2017
389115c
Ensure conflicted fields can be searchable and/or aggregatable (#13070)
chrisronline Jul 28, 2017
2430fed
Use version 0.9.0 of eslint-config-kibana (#13177)
weltenwort Jul 28, 2017
6748b22
Implement esTestCluster test util (#13099)
spalger Jul 28, 2017
5adc2cd
Should respect pinned filters (#13019)
thomasneirynck Jul 28, 2017
7d94bb1
[esTestConfig] fix esvm directory (#13190)
spalger Jul 28, 2017
b678b4b
Add Checks to Dashboard Context (#13182)
simianhacker Jul 28, 2017
d36080b
[testUtils/esTestCluster] use more standard api style (#13197)
spalger Jul 28, 2017
74cd8b1
Update saved objects client usage to `attributes` instead of `_source…
chrisronline Jul 31, 2017
abcc055
update spy table headers when columns update (#13130)
nreese Jul 31, 2017
9389f0b
[server/indexPatterns] expose indexPatternService getter/factory (#13…
spalger Jul 31, 2017
5772f56
Remove `@elastic` folder from `packages/` (#13089)
kimjoar Jul 31, 2017
18f8455
Add some functional tests for query language switching (#13036)
Bargs Jul 31, 2017
99a991b
[docs] Add docker-compose version to example (#13006)
jbudz Aug 1, 2017
baabbdf
removes :filters from label (#12962)
ppisljar Aug 1, 2017
5703ffc
in percentage mode tooltip should also show percentages (#13217)
ppisljar Aug 1, 2017
0353735
Exclude stacktrace from error response of Timelion backend (#12973)
thomasneirynck Aug 1, 2017
9057937
Send map filters through so it get picked up by both kuery and lucen…
Bargs Aug 1, 2017
f37eab9
[Framework/Accessibility] Add kuiScreenReaderOnly class (#13133)
tsullivan Aug 1, 2017
08719cd
[UI Framework] Spawn compileCss as a child process to prevent a node-…
cjcenizal Aug 1, 2017
3838fa5
ensure we are working with data-series (#13266)
thomasneirynck Aug 1, 2017
c33ac75
Revert "override version until elastic/elasticsearch#25876 is merged"…
epixa Aug 2, 2017
0aa4206
[npm] upgrade postcss-loader (#13279)
spalger Aug 2, 2017
10280e8
Add Kibana API plugin (#13206)
ytzlax Aug 2, 2017
f78bb5d
Add Kuery docs and break search page into subsections (#13074)
Bargs Aug 2, 2017
c68c0d6
[ui/routes] clone defaults before apply (#13295)
spalger Aug 2, 2017
cb222d7
Introduce logging `JsonLayout`. (#13180)
azasypkin Aug 3, 2017
432e6c1
Print `error.stack` for pattern layout and `error.message`, `error.st…
azasypkin Aug 3, 2017
b670bae
Add AirBnB linting rules for React best practices. Bump to v0.10.0. (…
cjcenizal Aug 3, 2017
e57c4fb
Visualization accessibility issues (#13226)
thomasneirynck Aug 3, 2017
4f5313a
Make sure no one can show the chrome if the default setting is hidden…
stacey-gammon Aug 3, 2017
7e28e98
[visualize spy] Pull index title instead of id (#13254)
jbudz Aug 3, 2017
6648335
[Accessibilty] Make kbn_accessible_click part of autoload/all (#13299)
tsullivan Aug 3, 2017
5fe682d
Improve region map documentation (#13319)
thomasneirynck Aug 3, 2017
8a1cdf1
fix typo
thomasneirynck Aug 3, 2017
14c9b7e
Use ui-select for agg selector (#13292)
lukasolson Aug 3, 2017
3e3b0cb
resize was not detected correctly (#13239)
ppisljar Aug 4, 2017
3dfcf5d
Remove simple_query_string hack now that multi_match supports * (#13285)
Bargs Aug 4, 2017
a4b72f2
Add documentation link to query bar when Kuery is selected (#13300)
Bargs Aug 4, 2017
8ee85f8
Add some testSubject helpers (#13305)
spalger Aug 5, 2017
161b07a
Fix full screen toggle button when panel is expanded (#13320)
stacey-gammon Aug 7, 2017
8cfbb82
Mock out static files when running in Jest (#13315)
sorenlouv Aug 7, 2017
47db80d
[docs] Add css style guide section on open/closed principle (#12276)
weltenwort Aug 7, 2017
ab8668a
Fix accessibility issues with saved object finder (#13152)
stacey-gammon Aug 7, 2017
5462275
Remove highlight query (#13231)
lukasolson Aug 7, 2017
d71bea6
Move build-info to status page (#13341)
timroes Aug 8, 2017
32b12c7
Update new-platform dependencies. (#13338)
azasypkin Aug 8, 2017
9f05b8d
Show full screen option even when write controls are hidden (#13247)
stacey-gammon Aug 8, 2017
6e74452
Create the concept of embeddableHandlers (#12146)
stacey-gammon Aug 8, 2017
9aed822
Use find service instead of remote (#13296)
stacey-gammon Aug 8, 2017
9dbd10d
Add support for `Router.post` method and `body` validation. (#13389)
azasypkin Aug 8, 2017
542d553
Make filter pills keyboard accessible (#13331)
Bargs Aug 8, 2017
b5e13ff
Fix dark theme issues with spy toggle and spy pane (#13345)
stacey-gammon Aug 8, 2017
9245488
[es/healthcheck] ensure that healthcheck stops when server is stopped…
spalger Aug 8, 2017
8a64872
[fix/UiSettings] ignore certain errors (#13079)
spalger Aug 9, 2017
fb203ea
Intentionally show spy pane in full screen mode, but not embed mode (…
stacey-gammon Aug 9, 2017
7199476
port k7 popover component over (#13322)
stacey-gammon Aug 9, 2017
3b0c820
Make 'all filters' actions keyboard accessible (#13391)
Bargs Aug 9, 2017
e545b12
Truncate long field names in filter editor (#13379)
lukasolson Aug 9, 2017
db4eb64
Be case insensitive when sorting on the visualize and dashboard landi…
stacey-gammon Aug 9, 2017
12142da
[server/stats] add server.getKibanaStats() for programatic access (#1…
spalger Aug 9, 2017
e66c1d2
Create keyboard mode for ui-ace editor (#13339)
timroes Aug 9, 2017
7e16d19
[npm] move personal forks into elastic org (#13410)
spalger Aug 9, 2017
3aa1f08
Use `bodyParser.json()` and `bodyParser.urlencoded() instead of depre…
azasypkin Aug 10, 2017
f1e5be8
Visualize Accessibility Issues (#13428)
thomasneirynck Aug 10, 2017
6193a7f
Remove esAdmin mention from docs since it no longer exists (#13449)
Bargs Aug 10, 2017
d12aa4b
[Management] Improve accessibility within management (#13364)
chrisronline Aug 10, 2017
6900e9e
Fix a bug with the interval label for TSVB (#13440)
simianhacker Aug 10, 2017
3a07e5c
[DOCS] Update links to Kibana security (#13456)
lcawl Aug 10, 2017
805c15c
Fixes #12685 - Improve error handling, add error for missing aggregat…
simianhacker Aug 10, 2017
2df0c27
ensure editor mode propagates correctly (#13355)
thomasneirynck Aug 10, 2017
4a06de8
Moving timezone functions from Timelion to Vis (#13457)
simianhacker Aug 10, 2017
17fcaf1
Fixes #13246 - Add checks for empty annotations (#13422)
simianhacker Aug 10, 2017
5d304b2
remove @bigfunger/jsondiffpatch (#13442)
epixa Aug 11, 2017
0a732a6
Fix KuiPopover examples. (#13461)
cjcenizal Aug 11, 2017
bbabe48
Avoid a wrapped retry and use exists instead of find, which will take…
stacey-gammon Aug 11, 2017
720297d
[UI Framework] Reorganize UI Framework and add Yeoman generator (#13172)
cjcenizal Aug 11, 2017
9671486
[UI Framework] Add functionality for hiding and showing the chrome wh…
cjcenizal Aug 11, 2017
fbaf4e6
[eslint-config-kibana] Upgrade eslint-config to 0.10.0. (#13323)
cjcenizal Aug 11, 2017
dfc6408
[DOCS] Use shared versions file for doc builds (#13277)
lcawl Aug 11, 2017
2fbfa53
github: PR template checklist in a comment
epixa Aug 12, 2017
99f1c65
Initial version of accessibility guide (#13390)
timroes Aug 14, 2017
c12ef6f
Fixes #12113 - Add timezone to date histogram aggregations for TSVB (…
simianhacker Aug 14, 2017
071e983
Prevents canceling index pattern modal from throwing error (#13488)
tylersmalley Aug 15, 2017
92e795a
Improve accessibility of the discover app (#13498)
timroes Aug 15, 2017
f2782d6
#10569 Fixes the position of spy tab buttons at the top of the widget…
varunsharma27 Aug 15, 2017
c4c6ea1
Handle booleans in filter editor (#13406)
lukasolson Aug 16, 2017
0920a99
Adds getAriaName function and applies it to advanced settings (#13448)
BigFunger Aug 16, 2017
911467a
Prevents default index pattern name when ID is provided (#13353)
tylersmalley Aug 16, 2017
8cd2696
remove spammy console.log()
spalger Aug 17, 2017
e09b914
Fix fixed-scroll on Discover page (#13516)
Bargs Aug 17, 2017
375ee3b
[ui/queryBar/tests] attach $elem to DOM so "click" triggers "submit" …
spalger Aug 17, 2017
f66c5db
Improve Dev Tools accessibility (#13496)
timroes Aug 18, 2017
ef67957
Improve accessibility of visualizations (#13507)
timroes Aug 18, 2017
7fb2d7f
Duration Formatting for TSVB (#13337)
simianhacker Aug 18, 2017
61c3f38
[console] Replace text/plain fallback with application/json (#12294)
jbudz Aug 18, 2017
e7ca195
Improves dark theme support in the filter editor (#13522)
Bargs Aug 18, 2017
e0708ab
Add aria describes for warning label, #12864 (#13576)
chrisronline Aug 18, 2017
abb54ac
Fix breaking scope changes in the field format editor samples (#13549)
chrisronline Aug 18, 2017
9e48298
Emphasize important difference between Kuery and Lucene query syntax …
Bargs Aug 18, 2017
8aaa900
Fixes #12866 - Use devicePixelRatio to scale up and down canvas value…
simianhacker Aug 18, 2017
cb5f508
[UI Framework] [K7] Improve generator snippets (#13598) (#13599)
cjcenizal Aug 18, 2017
64a1e0c
[Accessibility] Make table pagination controls keyboard-accessible. …
cjcenizal Aug 19, 2017
8141e3f
[savedObjectClient] decorate non-es errors too (#13596)
spalger Aug 19, 2017
529a9e3
Improve timelion accessibility (#13531)
timroes Aug 21, 2017
5b43727
fix available metric aggs (#13518)
thomasneirynck Aug 21, 2017
eeb4862
Fix discover sidebar Visualize button for geo_point fields (#13539)
Bargs Aug 21, 2017
45b10fb
[UI Framework] Add KuiOutsideClickDetector (#13521)
cjcenizal Aug 21, 2017
96a9160
Fix bug with Dashboard breadcrumb alignment. (#13580)
cjcenizal Aug 21, 2017
f6ba3d9
remove geo_bounds agg from visualizations (#13536)
thomasneirynck Aug 21, 2017
bf8fb46
added a helper method- selectIndexPattern method (#13568)
rashmivkulkarni Aug 22, 2017
9a34992
[chrome/nav/lastUrl] do not track redirect routes (#13432)
spalger Aug 22, 2017
6dfc7e0
Upgrade Node + TypeScript (#13609)
kimjoar Aug 22, 2017
5514f34
Show a warning for non accessible charts for screen readers (#13573)
timroes Aug 22, 2017
9890d22
Disable creation of "exists" filters for scripted fields (#13538)
Bargs Aug 22, 2017
49ba9e8
[UI Bundler] Add Aliases for Moment so plugins can use the same insta…
tsullivan Aug 22, 2017
0d281a7
Replace "marked" with "markdown-it" (#13623)
nreese Aug 22, 2017
599c8c4
Upgrade kibana to leaflet 1.x (#12367)
nreese Aug 22, 2017
8cceb73
Use "curl -O" for Darwin (#13602)
izeye Aug 23, 2017
094587c
Add interval doc (#13629)
thomasneirynck Aug 23, 2017
4117520
don't hide metric if show labels is false (#13637)
ppisljar Aug 23, 2017
7b836f9
Shortcut to build asciidocs (#13164)
epixa Aug 23, 2017
d3a62e8
Remove custom keyboard mode in datepicker (#13644)
timroes Aug 23, 2017
4bbd127
Removes webpack-directory-name-as-main dependency (#13584)
tylersmalley Aug 23, 2017
7e7ff40
Merge branch 'master' into new-platform
kimjoar Aug 24, 2017
0ebaa8d
Fix dates in tests (#13744)
kimjoar Aug 29, 2017
6f9eec4
Make core plugins use `kbn-types`
kimjoar Jul 19, 2017
1ec709d
Extract core plugins
kimjoar Aug 24, 2017
407cbb6
Add package lock files
kimjoar Aug 24, 2017
a0c309c
Move `getPluginDir` into `Env`
kimjoar Aug 29, 2017
2bc67cd
Review fixes
kimjoar Aug 31, 2017
628180f
Ensure 'target' is removed before re-building plugin
kimjoar Aug 31, 2017
6605033
Update package.lock
kimjoar Aug 31, 2017
27640f8
Run prettier
kimjoar Aug 31, 2017
0b430dc
Fix typo
kimjoar Aug 31, 2017
0a6ebb5
Remove unnecessary mention of tsconfig.json
kimjoar Aug 31, 2017
75a4a6f
Update platform readme
kimjoar Aug 31, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove simple_query_string hack now that multi_match supports * (elas…
Bargs authored Aug 4, 2017
commit 3dfcf5dc9850e1b16c24215c0737ea4ea9ef9720
5 changes: 3 additions & 2 deletions src/ui/public/kuery/functions/__tests__/and.js
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@ import { nodeTypes } from '../../node_types';
import * as ast from '../../ast';
import StubbedLogstashIndexPatternProvider from 'fixtures/stubbed_logstash_index_pattern';
import ngMock from 'ng_mock';
import { expectDeepEqual } from '../../../../../test_utils/expect_deep_equal';

let indexPattern;

@@ -54,11 +55,11 @@ describe('kuery functions', function () {

it('should wrap a literal argument with an "is" function targeting all fields', function () {
const literalFoo = nodeTypes.literal.buildNode('foo');
const expectedChild = ast.toElasticsearchQuery(nodeTypes.function.buildNode('is', '*', 'foo'), indexPattern);
const node = nodeTypes.function.buildNode('and', [literalFoo]);
const result = and.toElasticsearchQuery(node, indexPattern);
const resultChild = result.bool.filter[0];
expect(resultChild).to.have.property('simple_query_string');
expect(resultChild.simple_query_string.all_fields).to.be(true);
expectDeepEqual(resultChild, expectedChild);
});

});
34 changes: 11 additions & 23 deletions src/ui/public/kuery/functions/__tests__/is.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import expect from 'expect.js';
import * as is from '../is';
import { nodeTypes } from '../../node_types';
import _ from 'lodash';
import StubbedLogstashIndexPatternProvider from 'fixtures/stubbed_logstash_index_pattern';
import ngMock from 'ng_mock';
import { expectDeepEqual } from '../../../../../test_utils/expect_deep_equal';

let indexPattern;

@@ -54,34 +54,22 @@ describe('kuery functions', function () {

const node = nodeTypes.function.buildNode('is', '*', '*');
const result = is.toElasticsearchQuery(node, indexPattern);
expect(_.isEqual(expected, result)).to.be(true);
expectDeepEqual(result, expected);
});

it('should return an ES simple_query_string query in all fields mode when fieldName is "*"', function () {
it('should return an ES multi_match query when fieldName is "*"', function () {
const expected = {
simple_query_string: {
query: '"200"',
all_fields: true,
multi_match: {
query: 200,
fields: ['*'],
type: 'phrase',
lenient: true,
}
};

const node = nodeTypes.function.buildNode('is', '*', 200);
const result = is.toElasticsearchQuery(node, indexPattern);
expect(_.isEqual(expected, result)).to.be(true);
});

// See discussion about kuery escaping for background:
// https://github.com/elastic/kibana/pull/12624#issuecomment-312650307
it('should ensure the simple_query_string query is wrapped in double quotes to force a phrase search', function () {
const node = nodeTypes.function.buildNode('is', '*', '+response');
const result = is.toElasticsearchQuery(node, indexPattern);
expect(result.simple_query_string.query).to.be('"+response"');
});

it('already double quoted phrases should not get wrapped a second time', function () {
const node = nodeTypes.function.buildNode('is', '*', '"+response"');
const result = is.toElasticsearchQuery(node, indexPattern);
expect(result.simple_query_string.query).to.be('"+response"');
expectDeepEqual(result, expected);
});

it('should return an ES exists query when value is "*"', function () {
@@ -91,7 +79,7 @@ describe('kuery functions', function () {

const node = nodeTypes.function.buildNode('is', 'response', '*');
const result = is.toElasticsearchQuery(node, indexPattern);
expect(_.isEqual(expected, result)).to.be(true);
expectDeepEqual(result, expected);
});

it('should return an ES match_phrase query when a concrete fieldName and value are provided', function () {
@@ -103,7 +91,7 @@ describe('kuery functions', function () {

const node = nodeTypes.function.buildNode('is', 'response', 200);
const result = is.toElasticsearchQuery(node, indexPattern);
expect(_.isEqual(expected, result)).to.be(true);
expectDeepEqual(result, expected);
});

it('should support scripted fields', function () {
5 changes: 3 additions & 2 deletions src/ui/public/kuery/functions/__tests__/not.js
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@ import { nodeTypes } from '../../node_types';
import * as ast from '../../ast';
import StubbedLogstashIndexPatternProvider from 'fixtures/stubbed_logstash_index_pattern';
import ngMock from 'ng_mock';
import { expectDeepEqual } from '../../../../../test_utils/expect_deep_equal';

let indexPattern;

@@ -49,11 +50,11 @@ describe('kuery functions', function () {

it('should wrap a literal argument with an "is" function targeting all fields', function () {
const literalFoo = nodeTypes.literal.buildNode('foo');
const expectedChild = ast.toElasticsearchQuery(nodeTypes.function.buildNode('is', '*', 'foo'), indexPattern);
const node = nodeTypes.function.buildNode('not', literalFoo);
const result = not.toElasticsearchQuery(node, indexPattern);
const resultChild = result.bool.must_not;
expect(resultChild).to.have.property('simple_query_string');
expect(resultChild.simple_query_string.all_fields).to.be(true);
expectDeepEqual(resultChild, expectedChild);
});

});
5 changes: 3 additions & 2 deletions src/ui/public/kuery/functions/__tests__/or.js
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@ import { nodeTypes } from '../../node_types';
import * as ast from '../../ast';
import StubbedLogstashIndexPatternProvider from 'fixtures/stubbed_logstash_index_pattern';
import ngMock from 'ng_mock';
import { expectDeepEqual } from '../../../../../test_utils/expect_deep_equal';

let indexPattern;

@@ -54,11 +55,11 @@ describe('kuery functions', function () {

it('should wrap a literal argument with an "is" function targeting all fields', function () {
const literalFoo = nodeTypes.literal.buildNode('foo');
const expectedChild = ast.toElasticsearchQuery(nodeTypes.function.buildNode('is', '*', 'foo'), indexPattern);
const node = nodeTypes.function.buildNode('or', [literalFoo]);
const result = or.toElasticsearchQuery(node, indexPattern);
const resultChild = result.bool.should[0];
expect(resultChild).to.have.property('simple_query_string');
expect(resultChild.simple_query_string.all_fields).to.be(true);
expectDeepEqual(resultChild, expectedChild);
});

it('should require one of the clauses to match', function () {
16 changes: 5 additions & 11 deletions src/ui/public/kuery/functions/is.js
Original file line number Diff line number Diff line change
@@ -33,13 +33,12 @@ export function toElasticsearchQuery(node, indexPattern) {
return { match_all: {} };
}
else if (fieldName === '*' && value !== '*') {
const userQuery = String(value);
const query = isDoubleQuoted(userQuery) ? userQuery : `"${userQuery}"`;

return {
simple_query_string: {
query,
all_fields: true
multi_match: {
query: value,
fields: ['*'],
type: 'phrase',
lenient: true,
}
};
}
@@ -68,8 +67,3 @@ export function toKueryExpression(node) {

return `${fieldName}:${value}`;
}

function isDoubleQuoted(str) {
return str.startsWith('"') && str.endsWith('"');
}