fix: Improve comparison performance (vercel#2973)

use deep comparison instead of hashing the fetch body
kimdaeyeub · Jun 20, 2024 · 76b18db · 76b18db
1 parent 3f98283
commit 76b18db
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 7 deletions.
diff --git a/package.json b/package.json
@@ -167,6 +167,7 @@
     "trailingComma": "none"
   },
   "dependencies": {
+    "dequal": "^2.0.3",
     "use-sync-external-store": "^1.2.0"
   }
 }
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/_internal/utils/config.ts b/src/_internal/utils/config.ts
@@ -6,12 +6,14 @@ import type {
   ScopedMutator,
   Cache
 } from '../types'
-import { stableHash } from './hash'
+
 import { initCache } from './cache'
 import { preset } from './web-preset'
 import { slowConnection } from './env'
 import { isUndefined, noop, mergeObjects } from './shared'
 
+import { dequal } from 'dequal/lite'
+
 // error retry
 const onErrorRetry = (
   _: unknown,
@@ -37,8 +39,7 @@ const onErrorRetry = (
   setTimeout(revalidate, timeout, opts)
 }
 
-const compare = (currentData: any, newData: any) =>
-  stableHash(currentData) == stableHash(newData)
+const compare = dequal
 
 // Default cache provider
 const [cache, mutate] = initCache(new Map()) as [Cache<any>, ScopedMutator]