Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure create-user command #127

Merged
merged 6 commits into from
Feb 10, 2018
Merged

Secure create-user command #127

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d4acd2d
Secure create-user command
simonschaufi Feb 2, 2018
b58f177
Merge branch 'master' into secure-user-command
kevinpapst Feb 8, 2018
cd554cf
extract Method
simonschaufi Feb 9, 2018
adf8137
Add hint
simonschaufi Feb 10, 2018
ceffe44
added integration test #123
kevinpapst Feb 10, 2018
0f22c3e
code review #123
kevinpapst Feb 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ npm run prod

### Installation (development / demo)

Lets boostrap your environment by executing this commands (which is only available in dev environment):
Lets boostrap your environment by executing this commands (which is only available in dev environment):
```bash
bin/console kimai:reset-dev
```
Expand Down Expand Up @@ -95,13 +95,13 @@ Just use the built-in web server for your first tests:
bin/console server:run
```

This command will start a web server for Kimai. Now you can access the application in your browser at <http://127.0.0.1:8000/>.
This command will start a web server for Kimai. Now you can access the application in your browser at <http://127.0.0.1:8000/>.
You can stop the built-in web server by pressing `Ctrl + C` while you're in the terminal.


### Installation (live)

The database to use is up to you, but we would not recommend using the default SQLite database for production usage.
The database to use is up to you, but we would not recommend using the default SQLite database for production usage.
Please create your database and configure the connection string in your environment, e.g. with the `.env` file:
```
APP_ENV=prod
Expand All @@ -115,10 +115,10 @@ bin/console doctrine:schema:create
bin/console cache:warmup --env=prod
```

Create your first user:
Create your first user with the following command. You will be asked to enter a password afterwards.

```bash
bin/console kimai:create-user username password [email protected] ROLE_SUPER_ADMIN
bin/console kimai:create-user username [email protected] ROLE_SUPER_ADMIN
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+bin/console kimai:create-user username [email protected] ROLE_SUPER_ADMIN password

Either you can enter the password as optional last argument or you can enter it interactively for protecting your bash history

Copy link
Contributor Author

@simonschaufi simonschaufi Feb 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to write that in the Readme but in the full documentation. We don't want to encourage people for the first install to append it. For most of the people its just for the installation. then they will continue adding new users via the admin panel anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me, but currently there is nothing documented. Then don't add the last argument but add a sentence that the user is asked for the password.

```

For available roles, please refer to the [user documentation](var/docs/users.md).
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"ext-pdo_sqlite": "*",
"avanzu/admin-theme-bundle": "dev-kevinpapst",
"beberlei/DoctrineExtensions": "^1.0",
"dama/doctrine-test-bundle": "^4.0",
"erusev/parsedown": "^1.6",
"sensio/framework-extra-bundle": "^5.1",
"symfony/asset": "^4.0",
Expand All @@ -34,6 +33,7 @@
"white-october/pagerfanta-bundle": "^1.1"
},
"require-dev": {
"dama/doctrine-test-bundle": "^5.0",
"doctrine/doctrine-fixtures-bundle": "^3.0",
"friendsofphp/php-cs-fixer": "^2.10",
"phpunit/phpunit": "^6.5",
Expand Down
Loading