-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up custom console output with utils #712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I hadn't even considered aligning the printing
Okay! I wasn't originally planning on directly mimicking Cargo's internal implementation of the shell utilities, but seeing the merits of that, I renamed the functions as requested. I also added a Per your request, I also reverted all changes made to cargo add. It turns out the only instance of an uppercase message is inside cargo add, for what it's worth: Lines 582 to 585 in fdb12eb
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last things
Fixes an off-by-one relative to the rest of the project's output formatting.
Okay! I've cleaned up the git history quite a bit. Should be good to merge. |
Thanks! |
Use utility functions to simplify styling and make the existing styling and indentation more consistent.
A few instances of manual styling remain:
set_version.rs
andupgrade.rs
(these could use an aesthetic pass too though, since they look out of place).set_version
.This also serves as a step towards #682, as these utilities functions are similar in form to Cargo's shell output.