Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ehcache upgrade #431

Closed
wants to merge 2 commits into from
Closed

Ehcache upgrade #431

wants to merge 2 commits into from

Conversation

pierre
Copy link
Member

@pierre pierre commented Apr 28, 2022

No description provided.

pierre added 2 commits April 28, 2022 10:37
Migrate from com.ning.maven.plugins:maven-dependency-versions-check-plugin
to org.basepom.maven:dependency-versions-check-maven-plugin.

Signed-off-by: Pierre-Alexandre Meyer <[email protected]>
Signed-off-by: Pierre-Alexandre Meyer <[email protected]>
@pierre
Copy link
Member Author

pierre commented Apr 28, 2022

Maven doesn't properly resolve the JAXB version range, which makes the build fail:

[ERROR] Found a problem with the dependency com.sun.istack:istack-commons-runtime
  Resolved version is 3.0.12
  Version 3.0.12 was expected by artifacts: org.kill-bill.billing:killbill-platform-base, org.kill-bill.billing:killbill-platform-osgi, org.kill-bill.billing:killbill-platform-test, org.kill-bill.commons:killbill-xmlloader
  Version 4.0.0 was expected by artifacts: org.ehcache:ehcache, org.ehcache:ehcache-clustered
[ERROR] Found a problem with the dependency jakarta.xml.bind:jakarta.xml.bind-api
  Resolved version is 2.3.3
  Version 2.3.3 was expected by artifacts: org.kill-bill.billing.plugin:killbill-plugin-api-invoice, org.kill-bill.billing.plugin:killbill-plugin-api-notification, org.kill-bill.billing:killbill-api, org.kill-bill.billing:killbill-internal-api, org.kill-bill.billing:killbill-platform-base, org.kill-bill.billing:killbill-platform-osgi, org.kill-bill.billing:killbill-platform-osgi-api, org.kill-bill.billing:killbill-platform-test, org.kill-bill.commons:killbill-xmlloader
  Version 3.0.0 was expected by artifacts: org.ehcache:ehcache, org.ehcache:ehcache-clustered
[ERROR] Found a problem with the dependency org.glassfish.jaxb:jaxb-runtime
  Resolved version is 2.3.6
  Version 2.3.5 was expected by artifacts: org.kill-bill.billing:killbill-platform-base, org.kill-bill.billing:killbill-platform-osgi, org.kill-bill.billing:killbill-platform-test, org.kill-bill.commons:killbill-xmlloader
  Version 3.0.0-M5 was expected by artifacts: org.ehcache:ehcache, org.ehcache:ehcache-clustered
[ERROR] Found a problem with the dependency org.glassfish.jaxb:txw2
  Resolved version is 2.3.6
  Version 2.3.5 was expected by artifacts: org.kill-bill.billing:killbill-platform-base, org.kill-bill.billing:killbill-platform-osgi, org.kill-bill.billing:killbill-platform-test, org.kill-bill.commons:killbill-xmlloader
  Version 3.0.0-M5 was expected by artifacts: org.ehcache:ehcache, org.ehcache:ehcache-clustered

Compare with dependency:tree:

[INFO] +- org.ehcache:ehcache:jar:3.10.0:compile
[INFO] |  \- org.glassfish.jaxb:jaxb-runtime:jar:2.3.6:runtime
[INFO] |     +- org.glassfish.jaxb:txw2:jar:2.3.6:runtime
[INFO] |     \- com.sun.istack:istack-commons-runtime:jar:3.0.12:runtime
[INFO] +- org.ehcache:ehcache-clustered:jar:3.10.0:runtime

This is really an erroneous error thrown by the maven-dependency-versions-check-plugin, but there is no easy way to ignore it unfortunately. Until we are ready to complete the move to jakarta artifacts, we cannot upgrade Ehcache.

Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant