-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🔨 Update migration script to use
v1-route-convention
package
Fix #46
- Loading branch information
Showing
2 changed files
with
22 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a6250a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kiliman this commit made it so the migrate doesn't actually do anything anymore
1a6250a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. You're right. I must have gotten distracted and never actually finished the implementation.
1a6250a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kiliman when it does the path validation, it ends up fighting with the remix route package as well since the cli looks from root but the remix route package looks from ./app. So
migrate ./app/routes ./app/flat-routes
ends up with an error that ./app/app/routes cannot be found.1a6250a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow... must have been asleep when I wrote that code. Very sorry about that. I'll try to get a working version up soon.
1a6250a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kiliman no problem, I was able to bypass the issue by fixing it in my local version but I didn't have time to upstream those changes. Thanks for the package!