Fix DataGrid GroupRow styles #370
Open
+25
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim to fix the DataGrid GroupRow styles as explaned in #363
(Help wanted) It still has some annoyances I can't get to work:
SukiUI.Demo_2024-12-28_17-59-15.mp4
As we don't include DataGrid theme from Avalonia there are many things missing, as for example, we can't aim
DataGridRowtype for inline styling of row because it does not exists as ControlTheme:<ControlTheme x:Key="{x:Type DataGridRow}" TargetType="DataGridRow">.A better approach would be include default DataGrid theme and override the key parts on Suki, or copy over from Avalonia and change every element to match Suki.
The Fluent theme of DataGrid already include many ResourceDictionary that we can tune, however some key parts are still missing.
Sample effect of lacking stock ControlThemes:
