Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] for project files and package generation #342

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

Insire
Copy link
Contributor

@Insire Insire commented Nov 30, 2024

Relevant changes

  • added Directory.Build.props, Directory.Packages.props to centrally manage nuget package versions and global project settings (speeds up managing nuget packages via IDE dramatically)
  • added [*.{csproj,props}] to editorconfig, to enforce uniform formatting for props and csproj files
  • auto formatted csproj and props files according to new editorconfig settings

Breaking Changes

  • use netstandard2.0 for SukiUI.Dock
  • added tags to SukiUI.Dock

Misc

  • fixed ambiguous reference in ToastsViewModel
  • added most recent .NET 8 version of System.Text.Json to Demo app, to fix a transitive package vulnerability

…nage nuget package versions and global project settings

added [*.{csproj,props}] to editorconfig, to enforce uniform formatting for props and csproj files
reformatted csproj files
refactor project and package settings, added tags to SukiUI.Dock
@Insire
Copy link
Contributor Author

Insire commented Nov 30, 2024

Not sure why SukiUI.Dock was using .NET 8.0, when SukiUI itself was .netstandard2.0. So i upgraded that. If there is a specific reason why SukiUI.Dock should remain on .NET 8.0, i will happily revert that change.

@kikipoulet kikipoulet merged commit 529642f into kikipoulet:main Dec 2, 2024
1 check passed
@Insire Insire deleted the central_package_management branch December 2, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants