Fix touch input in SukiSideMenuItem #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #333. I tested this on a touch capable monitor and it appears to resolve the issue. Essentially, it seems the OnPointerPressed method was incompletely copied from ListBoxItem, and OnPointerReleased was omitted entirely. This PR copies both methods from ListBoxItem, but changing the
ItemsControl.ItemsControlFromItemContainer(this) is ListBox ownertoItemsControl.ItemsControlFromItemContainer(this) is SukiSideMenu owner. There might be a more elegant way to handle these methods overrides, but I'm prioritizing just fixing the bug for now.