Support for RTL Layout #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dme-compunet
force-pushed
the
rtl-layout-compatibility
branch
from
18ca4b8 to
5ebaa77
Compare
|
RTL is not something I have a huge deal of experience with, but having checked out the commit locally, everything seems to be working as intended. This may end up being a fairly narrowly used feature, but supporting arabic/hebrew/etc. is probably a good idea, the fact this also toggles quite nicely and everything updates correctly is a big plus for runtime localisation. LGTM, but I'd want @kikipoulet to weigh in on a big feature addition instead of just merging it myself. |
|
Looks good to me too, that's great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SukiUI is one of the beautiful UIs I've seen, so it would be great if it supported RTL layout.
Note: In the current avalonia version of the project, there are some rendering issues in RTL mode that have been fixed in version 11.2.0. Please check this PR with the latest avalonia release.