Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump snakeyaml from 1.32 to 2.0 #2243

Closed
wants to merge 1 commit into from
Closed

Bump snakeyaml from 1.32 to 2.0 #2243

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 9, 2023 •
edited
Loading

Bumps snakeyaml from 1.32 to 2.0.

Commits
  • c98ffba issue 561: add negative test case
  • e2ca740 Use Maven wrapper on github
  • 49d91a1 Fix target for github
  • 19e331d Disable toolchain for github
  • 42c7812 Cobertura plugin does not work
  • 03c82b5 Rename GlobalTagRejectionTest to be run by Maven
  • 6e8cd89 Remove cobertura
  • d9b0f48 Improve Javadoc
  • 519791a Run install and site goals under docker
  • 82f33d2 Merge branch 'master' into add-module-info
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot
Bump snakeyaml from 1.32 to 2.0
94e21e2 
Bumps [snakeyaml](https://bitbucket.org/snakeyaml/snakeyaml) from 1.32 to 2.0.
- [Commits](https://bitbucket.org/snakeyaml/snakeyaml/branches/compare/snakeyaml-2.0..snakeyaml-1.32)

---
updated-dependencies:
- dependency-name: org.yaml:snakeyaml
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Mar 9, 2023
@mareknovotny
Copy link
Member

ok to test

@mareknovotny
Copy link
Member

jenkins do fdb

@mareknovotny
Copy link
Member

mareknovotny commented Apr 14, 2023 •
edited
Loading

Snakeyaml 2.0 seems not backward compatible with 1.32

@mareknovotny mareknovotny added the do_not_merge PR is not ready for merging label Apr 14, 2023
@mareknovotny
Copy link
Member

jenkins do fdb

@Ginxo
Copy link
Contributor

Ginxo commented May 10, 2023

looks like com.fasterxml.jackson needs to be upgraded
#2285
due to failures like
Caused by: java.lang.NoSuchMethodError: 'void org.yaml.snakeyaml.parser.ParserImpl.<init>(org.yaml.snakeyaml.reader.StreamReader)'

@Ginxo
Copy link
Contributor

Ginxo commented May 10, 2023 •
edited
Loading

snakeyaml 1.28 still present

[2023-05-09T11:44:40.407Z] [INFO] --< com.example:optaplanner-spring-boot-school-timetabling-quickstart >--
[2023-05-09T11:44:40.407Z] [INFO] Building OptaPlanner Quickstarts: School Timetabling (Spring Boot) 0.1.0-SNAPSHOT [16/19]
[2023-05-09T11:44:40.407Z] [INFO] --------------------------------[ jar ]---------------------------------
[2023-05-09T11:44:41.766Z] [INFO] 
[2023-05-09T11:44:41.766Z] [INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ optaplanner-spring-boot-school-timetabling-quickstart ---
[2023-05-09T11:44:42.021Z] [INFO] com.example:optaplanner-spring-boot-school-timetabling-quickstart:jar:0.1.0-SNAPSHOT
[2023-05-09T11:44:42.021Z] [INFO] +- org.springframework.boot:spring-boot-starter-web:jar:2.5.12:compile
[2023-05-09T11:44:42.021Z] [INFO] |  +- org.springframework.boot:spring-boot-starter:jar:2.5.12:compile
[2023-05-09T11:44:42.021Z] [INFO] |  |  +- org.springframework.boot:spring-boot:jar:2.5.12:compile
[2023-05-09T11:44:42.021Z] [INFO] |  |  +- org.springframework.boot:spring-boot-autoconfigure:jar:2.5.12:compile
[2023-05-09T11:44:42.021Z] [INFO] |  |  +- org.springframework.boot:spring-boot-starter-logging:jar:2.5.12:compile
[2023-05-09T11:44:42.021Z] [INFO] |  |  |  +- org.apache.logging.log4j:log4j-to-slf4j:jar:2.17.2:compile
[2023-05-09T11:44:42.021Z] [INFO] |  |  |  |  \- org.apache.logging.log4j:log4j-api:jar:2.17.2:compile
[2023-05-09T11:44:42.021Z] [INFO] |  |  |  \- org.slf4j:jul-to-slf4j:jar:1.7.36:compile
[2023-05-09T11:44:42.021Z] [INFO] |  |  +- jakarta.annotation:jakarta.annotation-api:jar:1.3.5:compile
[2023-05-09T11:44:42.021Z] [INFO] |  |  \- org.yaml:snakeyaml:jar:1.28:compile

This CVE-2022-1471 from snakeyaml:1.28 coming from spring-boot-starter-web is not affecting spring according to spring-projects/spring-framework#30048 a new PR to upgrade spring-boot to 2.7.10 has been open anyway for optaplanner-quickstarts https://github.com/kiegroup/optaplanner/pull/2821

@Ginxo
Copy link
Contributor

Ginxo commented May 10, 2023

I would suggest to close this one in favour of #2285

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 10, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@mareknovotny mareknovotny deleted the dependabot/maven/org.yaml-snakeyaml-2.0 branch May 10, 2023 11:57
@mareknovotny mareknovotny mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file do_not_merge PR is not ready for merging java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mareknovotny @Ginxo