Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for macOS 10.13 High Sierra #49

Merged
merged 5 commits into from
Oct 9, 2017
Merged

Add support for macOS 10.13 High Sierra #49

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ef07f4
Add support for macOS 10.13 High Sierra
ktheory Sep 28, 2017
87ea121
Remove legacy check
ktheory Sep 28, 2017
e26c034
Skip /usr/local ownership check on High Sierra
ktheory Sep 28, 2017
022162f
We can't change /usr/local only its subdirectories
talaris Oct 9, 2017
3b91405
Quotes cause shellcheck
talaris Oct 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions mac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,12 @@ exit_message() {
# shellcheck disable=SC2154
trap exit_message EXIT

## Check for OS X >= 10.10, <= 10.12
## Check for OS X >= 10.10, <= 10.13
if [ -n "$DANGER_ZONE" ]; then
print_warning "Skipping check of macOS/OS X version. 😎 DANGER ZONE"
else
if ! sw_vers -productVersion | grep -q "^10.1[0-2]"; then
print_error "Unsupported OS X version. Please use macOS Sierra, El Capitan, or Yosemite."
if ! sw_vers -productVersion | grep -q "^10.1[0-3]"; then
print_error "Unsupported OS X version. Please use macOS High Sierra, Sierra, El Capitan, or Yosemite."
print_error "Or set DANGER_ZONE=1 to proceed anyway."
exit 1
fi
Expand Down Expand Up @@ -179,20 +179,11 @@ if ! command -v brew >/dev/null; then
print_done
fi

# Workaround broken brew update from Aug 11
# https://github.com/Homebrew/homebrew-core#update-bug
# 1471233600 = Aug 15, 2016, after the issue.
brew_last_change=$(git --git-dir="$(brew --repo)"/.git log -n 1 --pretty=%at)
if [ "$brew_last_change" -le "1471233600" ]; then
print_status "Fixing brew update bug"
(cd "$(brew --repo)"; git fetch; git reset --hard origin/master; brew update) > /dev/null
print_done
fi

# Fix permission issue on /usr/local on OS 10.12
if [ ! -w /usr/local ]; then
# Fix permission issue on /usr/local on OS 10.12 or less
# NOTE: this may be obsolete
if sw_vers -productVersion | grep -q "^10.1[0-3]" && [ ! -w "$(brew --prefix)/Cellar" ]; then
print_status "Fixing /usr/local permissions issue"
sudo chown -R "$(whoami)" /usr/local
sudo chown -R "$(whoami)" sudo chown -R "$(whoami)" "$(brew --prefix)"/*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right...?

print_done
fi

Expand Down