Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBL-1768: RegisterTokenWorker to RXJava2 #2150

Merged
merged 3 commits into from
Oct 10, 2024
Merged

MBL-1768: RegisterTokenWorker to RXJava2 #2150

merged 3 commits into from
Oct 10, 2024
+20 −51

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Oct 9, 2024 •
edited
Loading

📲 What

  • One more migration to RXJava2

🛠 How

  • Reusable code by bringin RefreshPushToken interface implementation used as well in MessageService

👀 See

  • Take a look at datadog
  • Log in fresh in the app, you should see calls to push_tokens endpoint
Screenshot 2024-10-09 at 4 39 06 PM

| --- | --- |
| | |

📋 QA

  • Make sure you are logged out
  • Take a look at datadog or you Android Studio network profiler
  • See the calls to push_token endpoint

Story 📖

MBL-1768

@Arkariang Arkariang marked this pull request as ready for review October 9, 2024 23:41
@Arkariang Arkariang changed the title MBL-1768: RegisterTokenWorker to RXJava MBL-1768: RegisterTokenWorker to RXJava2 Oct 9, 2024
@Arkariang Arkariang self-assigned this Oct 9, 2024
@Arkariang Arkariang merged commit 73aff77 into master Oct 10, 2024
3 checks passed
@Arkariang Arkariang deleted the imartin/mbl-1768 branch October 10, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighdouglas leighdouglas leighdouglas approved these changes

@mtgriego mtgriego Awaiting requested review from mtgriego

@jlplks jlplks Awaiting requested review from jlplks

Assignees

@Arkariang Arkariang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkariang @leighdouglas