Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1748: PPO Polish - Error UI icon fix #2137

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

leighdouglas
Copy link
Contributor

@leighdouglas leighdouglas commented Sep 25, 2024

📲 What

Old UI was confusing - icon looked like a button to be pressed. We updated this to match other places in the app where we use an alert icon instead of a refresh arrow.

🛠 How

just updated the icon and created a new size

👀 See

Before:
Screenshot_20240709_115649

After:
iconstuff

📋 QA

Put phone into airplane mode and then navigate to the ppo page. should show new icon, and be the correct colors in light and dark mode.

Story 📖

MBL-1748: PPO Polish - Error UI icon fix

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.78%. Comparing base (f097ee7) to head (db2cb25).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2137   +/-   ##
=========================================
  Coverage     67.78%   67.78%           
  Complexity     2234     2234           
=========================================
  Files           368      368           
  Lines         22881    22881           
  Branches       3294     3294           
=========================================
  Hits          15509    15509           
  Misses         5600     5600           
  Partials       1772     1772           
Flag Coverage Δ
67.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leighdouglas leighdouglas marked this pull request as ready for review September 30, 2024 21:01
@leighdouglas leighdouglas merged commit 3ce4b30 into master Sep 30, 2024
3 checks passed
@leighdouglas leighdouglas deleted the leigh/mbl-1748-icon branch September 30, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants