Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-586: Unify rewards selection viewModels #2133

Merged
merged 11 commits into from
Sep 24, 2024

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Sep 23, 2024

📲 What

  • After reunifying checkout flows, for Rewards Carousel selection we were just using compose UI, but kept the old viewModel, in this PR we've extended LatePledges RewardSelectionViewModel to be able to support crowdfund as well, adding:
    • Alert shown during update pledge flow when user selecting a different reward and had backed add Ons
    • Analytics events
    • Obtain PledgeData to navigate to forward screens during crowdfund flow.
    • No more RXJava on Rewards Screens

🤔 Why

  • Unify checkout flows with new UI/architecture patterns

👀 See

  • Update pledge dialog
ShowAlertWhenUpdatingPledge.mp4
  • Late pledge keeps working as usual
LatePledgesNotShowsAlert.mp4

| --- | --- |
| | |

📋 QA

  • Pledge to a reward + addOns (no alert dialog should appear), update that pledge selecting a different reward, an alert dialog should appear, be able to navigate forward to addOns screen.
  • Pledge to a late pledges project, no alert dialog should appear

Story 📖

NMBL-1586

@Arkariang Arkariang marked this pull request as ready for review September 23, 2024 18:21
@Arkariang Arkariang self-assigned this Sep 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.

Project coverage is 67.77%. Comparing base (37f062f) to head (61065d0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...iewmodels/projectpage/RewardsSelectionViewModel.kt 67.64% 3 Missing and 8 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2133      +/-   ##
============================================
- Coverage     67.77%   67.77%   -0.01%     
- Complexity     2227     2233       +6     
============================================
  Files           368      368              
  Lines         22852    22881      +29     
  Branches       3283     3294      +11     
============================================
+ Hits          15489    15508      +19     
- Misses         5597     5600       +3     
- Partials       1766     1773       +7     
Flag Coverage Δ
67.77% <67.64%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arkariang Arkariang added the Pledge Redemption PRs related to Pledge Redemption 2024 label Sep 23, 2024
@Arkariang Arkariang merged commit 12923ee into master Sep 24, 2024
3 checks passed
@Arkariang Arkariang deleted the imartin/MBL-1586-unify-rewards-vm branch September 24, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pledge Redemption PRs related to Pledge Redemption 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants