Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1722: Extended feature flag client to check user enabled feature flags #2129

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Sep 12, 2024

📲 What

  • PPO Feature flag now checks remote config feature flag, and user enabled feature flags managed in flipper (backend feature flagging)

Story 📖

MBL-1722

@Arkariang Arkariang changed the title Imartin/mbl 1722 simple MBL-1722: Extended feature flag client to check user enabled feature flags Sep 12, 2024
@Arkariang Arkariang self-assigned this Sep 12, 2024
@Arkariang Arkariang marked this pull request as ready for review September 12, 2024 16:00
* Checks if the FlipperFlagKey.name is present within enabledFeatures
*/
fun isBackendEnabledFlag(privacy: Observable<UserPrivacy>, key: FlipperFlagKey): Observable<Boolean> {
return privacy.map { it.enabledFeatures.contains(key.key) }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the query:
Screenshot 2024-09-12 at 9 01 40 AM

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.78%. Comparing base (54d7405) to head (dc4c527).

Files with missing lines Patch % Lines
...arter/services/transformers/GraphQLTransformers.kt 33.33% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2129   +/-   ##
=========================================
  Coverage     67.78%   67.78%           
- Complexity     2225     2226    +1     
=========================================
  Files           368      368           
  Lines         22843    22850    +7     
  Branches       3281     3281           
=========================================
+ Hits          15483    15489    +6     
- Misses         5596     5597    +1     
  Partials       1764     1764           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arkariang Arkariang merged commit a2979cd into master Sep 12, 2024
3 checks passed
@Arkariang Arkariang deleted the imartin/MBL-1722-simple branch September 12, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants